Skip to content

change: [M3-7494] – Update copy for Linode "Reboot Needed" tooltip#9966

Merged
dwiley-akamai merged 2 commits intolinode:developfrom
dwiley-akamai:M3-7494-vpc-reboot-needed-ux-copy
Dec 6, 2023
Merged

change: [M3-7494] – Update copy for Linode "Reboot Needed" tooltip#9966
dwiley-akamai merged 2 commits intolinode:developfrom
dwiley-akamai:M3-7494-vpc-reboot-needed-ux-copy

Conversation

@dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Dec 6, 2023

Description 📝

Update VPC_REBOOT_MESSAGE with new copy for "Reboot Needed" tooltip.

Preview 📷

Screenshots

VPC Details page:
Screenshot 2023-12-06 at 10 42 20 AM

Linode Details page:
Screenshot 2023-12-06 at 10 42 02 AM

How to test 🧪

Prerequisites

  • Account with proper VPC tags

Verification steps

The easiest way to test this:

  • Assign a Linode to a subnet from the VPC Details page (subnet row --> three-dot menu --> "Assign Linodes")
  • Observe: the assigned Linode should appear in the subnet inner table with a status of "Reboot Needed" and a tooltip with the updated copy

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the VPC Relating to VPC project label Dec 6, 2023
@dwiley-akamai dwiley-akamai self-assigned this Dec 6, 2023
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner December 6, 2023 16:02
@dwiley-akamai dwiley-akamai requested review from carrillo-erik and mjac0bs and removed request for a team December 6, 2023 16:02
@github-actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.51%
Current Coverage: 86.51%

mjac0bs
mjac0bs approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Copy looks good.
Screenshot 2023-12-06 at 8 23 09 AM

This is an unrelated and minor, non-blocking edge-case observation, which would be best in a follow up PR if you choose to address it: I noticed that at some of the smaller screen sizes, the buttons in the row get out of alignment. Specifically, this happens between widths of 622 and 599, and then again at 439. See video.

Screen.Recording.2023-12-06.at.8.24.16.AM.mov

coliu-akamai
coliu-akamai approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy looks good! ✅

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Dec 6, 2023
@dwiley-akamai
Copy link
Contributor Author

dwiley-akamai commented Dec 6, 2023 •
edited
Loading

This is an unrelated and minor, non-blocking edge-case observation, which would be best in a follow up PR if you choose to address it: I noticed that at some of the smaller screen sizes, the buttons in the row get out of alignment. Specifically, this happens between widths of 622 and 599, and then again at 439. See video.

Thanks, I will create a ticket to track that issue (edit: created M3-7545)

@dwiley-akamai dwiley-akamai merged commit 2f8db07 into linode:develop Dec 6, 2023
@dwiley-akamai dwiley-akamai deleted the M3-7494-vpc-reboot-needed-ux-copy branch December 6, 2023 19:04
@mjac0bs mjac0bs mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/cloud-manager-code-reviewers

+1 more reviewer

@mjac0bs mjac0bs mjac0bs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dwiley-akamai dwiley-akamai

Labels

Approved Multiple approvals and ready to merge! VPC Relating to VPC project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwiley-akamai @mjac0bs @coliu-akamai @DevDW